Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSP-7177 h120 dropdowns typeahead #3600

Merged
merged 4 commits into from
Nov 20, 2023
Merged

PSP-7177 h120 dropdowns typeahead #3600

merged 4 commits into from
Nov 20, 2023

Conversation

asanchezr
Copy link
Collaborator

update-comp-req

@asanchezr asanchezr added the enhancement New feature or request label Nov 18, 2023
@asanchezr asanchezr self-assigned this Nov 18, 2023
@github-actions GitHub Actions
Copy link
Contributor

✅ No secrets were detected in the code.

@codecov Codecov
Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Merging #3600 (c7888b8) into dev (c61e282) will increase coverage by 5.08%.
The diff coverage is 73.91%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3600      +/-   ##
==========================================
+ Coverage   69.61%   74.69%   +5.08%     
==========================================
  Files        1372      899     -473     
  Lines       33968    18722   -15246     
  Branches     6339     5322    -1017     
==========================================
- Hits        23646    13985    -9661     
+ Misses      10067     4737    -5330     
+ Partials      255        0     -255
Flag Coverage Δ
unittests 74.69% <73.91%> (+5.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...nsation/update/CompensationRequisitionYupSchema.ts 100.00% <ø> (ø)
.../update/UpdateCompensationRequisitionContainer.tsx 94.68% <ø> (ø)
...ation/update/UpdateCompensationRequisitionForm.tsx 64.83% <100.00%> (ø)
...n/update/financials/FinancialActivitiesSubForm.tsx 100.00% <ø> (ø)
...ation/detail/CompensationRequisitionDetailView.tsx 71.42% <50.00%> (-0.69%) ⬇️
...Bar/acquisition/tabs/compensation/update/models.ts 85.13% <73.80%> (-4.39%) ⬇️

... and 474 files with indirect coverage changes

@devinleighsmith devinleighsmith merged commit 630c08e into bcgov:dev Nov 20, 2023
9 checks passed
@asanchezr asanchezr deleted the psp-7177-h120-dropdowns branch November 20, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinleighsmith devinleighsmith devinleighsmith approved these changes

Assignees

@asanchezr asanchezr

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asanchezr @devinleighsmith